Use proper attributes for "previous" links #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Feel free to create a very welcomed PR also for the fix and improvement of the aria attributes. |
|
Should we merge this PR first, and take care of the aria attributes in a second PR? I'd like to read up on aria first just to make sure I got it right. |
Sure. If you decide to improve it, please, link also some reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
relattribute has been changed fromnexttoprevaria-labelattribute has been changed fromnexttopreviousI chose not to abbreviate the aria label as it's intended for screen readers, etc. In fact,
aria-labelledbymight be a better alternative as we already provide a description within the anchor text itself. But I decided not to address that issue in this PR.